Draft
Conversation
20d1eb6 to
b75553d
Compare
b75553d to
3aac91a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a docker image for folks to quickly and easily try UCM without installing it on their machine.
Unfortunately this isn't working for some reason, when I run the image I get:
Not sure if it's a mac codesigning thing or some other arcane thing.
Uploads to our Github Packages repo here:
https://github.com/unisonweb/unison/pkgs/container/unison
TODO:
Once we're happy with it we need to make the image public, which I may need help to do, here's what I see:
Implementation notes
latest,vx.y.z, andnightlytags as expectedFolks may want to docker run exposing port
8080so they can use the UI, though I doubtucm uiwill work since xdg-open is in the container.Test coverage
Nope
Loose ends